[Cluster-devel] Re: [PATCH] nfs: Fix nfs_readpages() error path

[Steven Whitehouse]

Hi,

On Sun, 2006-10-29 at 16:58 -0500, Trond Myklebust wrote:
> On Mon, 2006-10-30 at 05:40 +0900, OGAWA Hirofumi wrote:
> > Well, both seems right things for me. So, the patch was done by
> > minimum change for -rc. If you want it, I'll do.
> 
> Feel free. I should have time to work on it tomorrow, in case you don't
> find time today.
> 
> > BTW, umm.. now I think, gfs2_readpages() seems to have a bug in error
> > path by different way. unlock_page() is really needed?
> 
> That looks like a definite bug too.
> 
> Cheers,
>   Trond

Agreed. It will be fixed fairly shortly as part of a patch related to a
race when reading and truncating "stuffed" files,

Steve.