[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] cleanup build system a bit.



Fabio Massimo Di Nitto wrote:
I think this patch is something that we can commit to the -HEAD branch and start using for FC8 and beyond. We shouldn't have a problem patching up any minor issues that crop up. I vote for committing this patch.

Hi Fabio,

This looks like a good patch to me.  I've been too busy to look at it in
any great detail, but I did look at the highlights.  I have a minor concern
about the Makefile in gfs2/mkfs: IIRC, it looked like the default "Make" (all) specified only mkfs.gfs2 as the target, whereas we need to be sure to
that gfs2_jadd and gfs2_grow get built as well.  Er, well, I guess you don't
have gfs2_grow yet (but I do). Maybe it's already assured with some magic and trickery, as it often happens in many Makefiles, but that will be apparent
soon enough if/when I get a chance to try it.

As with any change with so many things affected, there might be some minor glitches or gotchas that we'll find, but I think we can work around those as we encounter them. Good job!

Regards,

Bob Peterson
Red Hat Cluster Suite


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]