[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] [GFS2] Clean up run_queue()



On Mon, Jul 30, 2007 at 10:32:15AM +0100, Steven Whitehouse wrote:
> A further clean up to make the logic a bit more obvious and
> remove a local variable which is no longer required.
> 
> Signed-off-by: Steven Whitehouse <swhiteho redhat com>
> 
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index 65d6eba..79d61ff 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -564,24 +564,19 @@ static int rq_demote(struct gfs2_glock *gl)
>   */
>  static void run_queue(struct gfs2_glock *gl)
>  {
> -	int blocked;
> -
> -	for (;;) {
> -		blocked = 1;
> -		if (test_bit(GLF_LOCK, &gl->gl_flags))
> -			break;
> -
> +	while(test_bit(GLF_LOCK, &gl->gl_flags) == 0) {

CodingStyle requires a space after while


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]