[Cluster-devel] Re: [PATCH] gfs2: better code for translating characters
H. Peter Anvin
hpa at zytor.com
Mon Aug 13 16:35:15 UTC 2007
rae l wrote:
> On 8/13/07, H. Peter Anvin <hpa at zytor.com> wrote:
>> You seem to have confused modern compiled C with an old BASIC interpreter.
>>
>> Consider the code in point:
>>
>> - while ((table = strchr(sdp->sd_table_name, '/')))
>> + table = sdp->sd_table_name;
>> + while ((table = strchr(table, '/')))
>> *table = '_';
> Sorry, I just mean for call to strchr, things are different,
> especially for multiple '/' chars appeared.
Things are different only for multiple '/' chars. In that case, the
latter form is better, in the former case, there is no difference.
So it doesn't matter. One is unambiguously better.
-hpa
More information about the Cluster-devel
mailing list