[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] [PATCH] Cleanup gfs_ondisk.h usage



Remove redundant gfs_ondisk.h from gfs/include/ and gfs2/include/

both files are outdated compared to the one shipped in
gfs-kernel/src/gfs/gfs_ondisk.h and there should be no need of
duplicates around the tree.

gfs and gfs2 both use to include gfskincdir that is enough to guarantee
that gfs_ondisk.h will be available at build time.

gfs2/mount/Makefile requires this one liner. I spotted that we try to include
gfs2kincdir that we never set and therefor it was failing to build without
a local copy of gfs_ondisk.h

Please apply or ACK and I will apply. This also means
rm gfs/include/gfs_ondisk.h gfs2/include/gfs_ondisk.h

Thanks
Fabio

Index: mount/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs2/mount/Makefile,v
retrieving revision 1.14
diff -u -r1.14 Makefile
--- mount/Makefile	1 Jun 2007 09:45:34 -0000	1.14
+++ mount/Makefile	19 Aug 2007 05:06:39 -0000
@@ -26,7 +26,7 @@
 CFLAGS += -DHELPER_PROGRAM -D_FILE_OFFSET_BITS=64
 CFLAGS += -DGFS2_RELEASE_NAME=\"${RELEASE}\" -D_GNU_SOURCE
 CFLAGS += -O2
-CFLAGS += -I${gfs2kincdir} -I${gfskincdir}
+CFLAGS += -I${gfskincdir}
 CFLAGS += -I../include
 CFLAGS += -I${incdir}
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]