[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] [PATCH] Minor Makefile's cleanup



-Wall is added by default in CFLAGS via configure to make/defines.mk.

Remove all the others redundant definitions.

Please apply or ACK and I will apply.

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.
? make/defines.mk
Index: ccs/ccs_tool/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/ccs/ccs_tool/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- ccs/ccs_tool/Makefile	22 Aug 2007 08:58:36 -0000	1.13
+++ ccs/ccs_tool/Makefile	26 Aug 2007 04:40:15 -0000
@@ -20,7 +20,7 @@
 	old_parser.o \
 	editconf.o
 
-CFLAGS += -Wall -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
+CFLAGS += -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
 CFLAGS += -I${ccsincdir} -I${cmanincdir} `xml2-config --cflags`
 CFLAGS += -I../include
 CFLAGS += -I${incdir}
Index: ccs/daemon/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/ccs/daemon/Makefile,v
retrieving revision 1.15
diff -u -r1.15 Makefile
--- ccs/daemon/Makefile	22 Aug 2007 08:58:36 -0000	1.15
+++ ccs/daemon/Makefile	26 Aug 2007 04:40:15 -0000
@@ -21,7 +21,6 @@
 	globals.o
 
 CFLAGS += -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
-CFLAGS += -Wall
 CFLAGS += -I${cmanincdir} `xml2-config --cflags`
 CFLAGS += -I. -I../include -I../common
 CFLAGS += -I${incdir}
Index: cman/qdisk/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/cman/qdisk/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- cman/qdisk/Makefile	1 Jun 2007 09:45:31 -0000	1.11
+++ cman/qdisk/Makefile	26 Aug 2007 04:40:15 -0000
@@ -13,7 +13,7 @@
 include ../../make/defines.mk
 
 CFLAGS += -D_GNU_SOURCE
-CFLAGS += -Wall -Werror -Wstrict-prototypes -Wshadow -g
+CFLAGS += -Werror -Wstrict-prototypes -Wshadow -g
 CFLAGS += -I${ccsincdir} -I${cmanincdir}
 CFLAGS += -I.
 CFLAGS += -I${incdir}
Index: dlm/tests/usertest/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/dlm/tests/usertest/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- dlm/tests/usertest/Makefile	24 Aug 2007 14:10:27 -0000	1.11
+++ dlm/tests/usertest/Makefile	26 Aug 2007 04:40:16 -0000
@@ -18,7 +18,7 @@
 all: depends ${TARGETS}
 
 CFLAGS += -D_REENTRANT
-CFLAGS += -Wall -g
+CFLAGS += -g
 CFLAGS += -I${dlmincdir}
 
 LDFLAGS += -L${dlmlibdir} -ldlm -lpthread
Index: fence/agents/xvm/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/fence/agents/xvm/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- fence/agents/xvm/Makefile	22 Aug 2007 08:58:41 -0000	1.13
+++ fence/agents/xvm/Makefile	26 Aug 2007 04:40:16 -0000
@@ -34,7 +34,7 @@
 		debug.o
 
 CFLAGS += -D_GNU_SOURCE
-CFLAGS += -Wall -Werror -Wstrict-prototypes -Wshadow -ggdb
+CFLAGS += -Werror -Wstrict-prototypes -Wshadow -ggdb
 CFLAGS += -I${ccsincdir} -I${cmanincdir} -I${openaisincdir}
 CFLAGS += -I${virtincdir} -I${nssincdir} -I${nsprincdir}
 CFLAGS += `xml2-config --cflags`
Index: gfs/gfs_tool/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs/gfs_tool/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- gfs/gfs_tool/Makefile	22 Aug 2007 08:58:44 -0000	1.13
+++ gfs/gfs_tool/Makefile	26 Aug 2007 04:40:16 -0000
@@ -26,7 +26,7 @@
 	util.o
 
 CFLAGS += -D_FILE_OFFSET_BITS=64
-CFLAGS += -O2 -Wall 
+CFLAGS += -O2
 CFLAGS += -I${gfskincdir}
 CFLAGS += -I../include
 CFLAGS += -I${incdir}
Index: gfs/libgfs/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs/libgfs/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- gfs/libgfs/Makefile	22 Aug 2007 08:58:45 -0000	1.8
+++ gfs/libgfs/Makefile	26 Aug 2007 04:40:16 -0000
@@ -17,7 +17,7 @@
 
 CFLAGS += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE
 CFLAGS += -D_GNU_SOURCE -DHELPER_PROGRAM
-CFLAGS += -c -Wall -ggdb 
+CFLAGS += -c -ggdb 
 CFLAGS += -I${KERNEL_SRC}/fs/gfs2/ -I${KERNEL_SRC}/include/
 CFLAGS += -I${gfskincdir} -I../include
 CFLAGS += -I${incdir}
Index: gfs2/convert/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs2/convert/Makefile,v
retrieving revision 1.10
diff -u -r1.10 Makefile
--- gfs2/convert/Makefile	22 Aug 2007 08:58:45 -0000	1.10
+++ gfs2/convert/Makefile	26 Aug 2007 04:40:17 -0000
@@ -17,7 +17,7 @@
 OBJS= gfs2_convert.o
 
 CFLAGS += -D_FILE_OFFSET_BITS=64 -DHELPER_PROGRAM
-CFLAGS += -Wall -g
+CFLAGS += -g
 CFLAGS += -I${KERNEL_SRC}/fs/gfs2/ -I${KERNEL_SRC}/include/
 CFLAGS += -I../include -I../libgfs2
 CFLAGS += -I${incdir}
Index: gfs2/fsck/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs2/fsck/Makefile,v
retrieving revision 1.14
diff -u -r1.14 Makefile
--- gfs2/fsck/Makefile	22 Aug 2007 08:58:46 -0000	1.14
+++ gfs2/fsck/Makefile	26 Aug 2007 04:40:17 -0000
@@ -35,7 +35,7 @@
 	util.o
 
 CFLAGS += -D_FILE_OFFSET_BITS=64 -DHELPER_PROGRAM
-CFLAGS += -MMD -Wall -O2
+CFLAGS += -MMD -O2
 CFLAGS += -I${KERNEL_SRC}/fs/gfs2/ -I${KERNEL_SRC}/include/
 CFLAGS += -I../include -I../libgfs2
 CFLAGS += -I${incdir}
Index: gfs2/libgfs2/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs2/libgfs2/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- gfs2/libgfs2/Makefile	22 Aug 2007 08:58:46 -0000	1.9
+++ gfs2/libgfs2/Makefile	26 Aug 2007 04:40:17 -0000
@@ -17,7 +17,7 @@
 
 ## Bob: add -O2 back in and take -ggdb out
 CFLAGS += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_GNU_SOURCE
-CFLAGS += -Wall -ggdb
+CFLAGS += -ggdb
 CFLAGS += -I${KERNEL_SRC}/fs/gfs2/ -I${KERNEL_SRC}/include/
 CFLAGS += -I../include
 CFLAGS += -I${incdir}
Index: gfs2/mkfs/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs2/mkfs/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- gfs2/mkfs/Makefile	22 Aug 2007 08:58:46 -0000	1.19
+++ gfs2/mkfs/Makefile	26 Aug 2007 04:40:17 -0000
@@ -16,7 +16,7 @@
 	main_jadd.o
 
 CFLAGS += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_GNU_SOURCE
-CFLAGS += -Wall -O2 -ggdb
+CFLAGS += -O2 -ggdb
 CFLAGS += -I${KERNEL_SRC}/include/
 CFLAGS += -I../include/ -I../libgfs2/
 CFLAGS += -I${incdir}
Index: gfs2/tool/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs2/tool/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- gfs2/tool/Makefile	22 Aug 2007 08:58:46 -0000	1.11
+++ gfs2/tool/Makefile	26 Aug 2007 04:40:17 -0000
@@ -26,7 +26,7 @@
 	util.o
 
 CFLAGS += -D_FILE_OFFSET_BITS=64
-CFLAGS += -O2 -Wall
+CFLAGS += -O2
 CFLAGS += -I${KERNEL_SRC}/fs/gfs2/ -I${KERNEL_SRC}/include/
 CFLAGS += -I../include
 CFLAGS += -I${incdir}

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]