[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] [RFC] Switch the entire project to use -Werror



The patch is pretty much self explanatory and depends on the other 2 patches I
already posted.

most of the subprojects already build fine with -Werror, but at least 2 won't.
Applying this patch will require a bit of effort from different maintainers
to fix build warnings. I also opened a bugzilla for it a while ago.

If there is agreement on this change, I can provide access and/or build logs
from CVS HEAD built on different architectures (other than usual x86* suspects).
I have handy ppc/sparc/parisc/ia64 at least. The build logs will be on Ubuntu
machines but I am sure you guys at RedHat can survive that :P

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.
diff -Narud redhat-cluster-suite-2.20070823/cman/qdisk/Makefile cluster/cman/qdisk/Makefile
--- redhat-cluster-suite-2.20070823/cman/qdisk/Makefile	2007-08-26 07:36:56.000000000 +0200
+++ cluster/cman/qdisk/Makefile	2007-08-26 07:41:24.000000000 +0200
@@ -13,7 +13,7 @@
 include ../../make/defines.mk
 
 CFLAGS += -D_GNU_SOURCE
-CFLAGS += -Werror -Wstrict-prototypes -Wshadow
+CFLAGS += -Wstrict-prototypes -Wshadow
 CFLAGS += -I${ccsincdir} -I${cmanincdir}
 CFLAGS += -I.
 CFLAGS += -I${incdir}
diff -Narud redhat-cluster-suite-2.20070823/configure cluster/configure
--- redhat-cluster-suite-2.20070823/configure	2007-08-26 07:36:56.000000000 +0200
+++ cluster/configure	2007-08-26 07:41:09.000000000 +0200
@@ -133,8 +133,8 @@
   print "--module_dir=\tthe base directory for kernel modules.  (Default:  /lib/modules/`uname -r`/kernel\n";
   print "\nbuild flags:\n";
   print "--cc=\t\tcompiler to use.  (Default: gcc)\n";
-  print "--debug\t\tEnable debugging build. Changes default CFLAGS to -Wall -O0 -DDEBUG -g.\n";
-  print "--cflags=\toverride default CFLAGS settings.  (Default: -Wall -O2 -g)\n";
+  print "--debug\t\tEnable debugging build. Changes default CFLAGS to -Wall -Werror -O0 -DDEBUG -g.\n";
+  print "--cflags=\toverride default CFLAGS settings.  (Default: -Wall -Werror -O2 -g)\n";
   print "--extracflags=\tadd extra compiler options to default CFLAGS setting.  (Default: none)\n";
   print "--ldflags=\toverride default LDFLAGS settings.  (Default: none)\n";
   print "--extraldflags=\tadd extra linking options to default LDFLAGS settings.  (Default: none)\n";
@@ -175,7 +175,7 @@
   $cc="gcc";
 }
 if (!$cflags) {
-  $cflags="-Wall";
+  $cflags="-Wall -Werror";
   if (!$debug) {
     $cflags="${cflags} -O2";
   } else {
diff -Narud redhat-cluster-suite-2.20070823/rgmanager/src/clulib/Makefile cluster/rgmanager/src/clulib/Makefile
--- redhat-cluster-suite-2.20070823/rgmanager/src/clulib/Makefile	2007-08-26 07:36:56.000000000 +0200
+++ cluster/rgmanager/src/clulib/Makefile	2007-08-26 07:41:45.000000000 +0200
@@ -25,7 +25,7 @@
 
 OBJS3= msgtest.o
 
-CFLAGS += -Werror -Wstrict-prototypes -Wshadow -fPIC -D_GNU_SOURCE
+CFLAGS += -Wstrict-prototypes -Wshadow -fPIC -D_GNU_SOURCE
 CFLAGS += -I${cmanincdir} -I${dlmincdir}
 CFLAGS += -I../../include
 CFLAGS += -I${incdir}
diff -Narud redhat-cluster-suite-2.20070823/rgmanager/src/daemons/Makefile cluster/rgmanager/src/daemons/Makefile
--- redhat-cluster-suite-2.20070823/rgmanager/src/daemons/Makefile	2007-08-26 07:36:56.000000000 +0200
+++ cluster/rgmanager/src/daemons/Makefile	2007-08-26 07:41:36.000000000 +0200
@@ -48,7 +48,7 @@
 		rg_locks-noccs.o
 
 CFLAGS += -D_GNU_SOURCE -DSHAREDIR=\"${sharedir}\"
-CFLAGS += -Werror -Wstrict-prototypes -Wshadow -fPIC
+CFLAGS += -Wstrict-prototypes -Wshadow -fPIC
 CFLAGS += -I${ccsincdir} -I${cmanincdir} -I${dlmincdir}
 CFLAGS += `xml2-config --cflags` -I${readlineincdir}
 CFLAGS += -I../../include
diff -Narud redhat-cluster-suite-2.20070823/rgmanager/src/utils/Makefile cluster/rgmanager/src/utils/Makefile
--- redhat-cluster-suite-2.20070823/rgmanager/src/utils/Makefile	2007-08-26 07:36:56.000000000 +0200
+++ cluster/rgmanager/src/utils/Makefile	2007-08-26 07:41:56.000000000 +0200
@@ -21,7 +21,7 @@
 
 DISABLEDTARGETS= cluarp
 
-CFLAGS += -Werror -Wstrict-prototypes -Wshadow -fPIC -D_GNU_SOURCE
+CFLAGS += -Wstrict-prototypes -Wshadow -fPIC -D_GNU_SOURCE
 CFLAGS += -I${ccsincdir} -I${cmanincdir} -I${dlmincdir} -I${ncursesincdir}
 CFLAGS += -I../../include
 CFLAGS += -I${incdir}

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]