[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] Cleanup some common CFLAGS



On Sun, Aug 26, 2007 at 07:35:24AM +0200, Fabio Massimo Di Nitto wrote:
> diff -Naurd redhat-cluster-suite-2.20070823/cman/qdisk/Makefile cluster/cman/qdisk/Makefile
> --- redhat-cluster-suite-2.20070823/cman/qdisk/Makefile	2007-08-26 07:02:55.000000000 +0200
> +++ cluster/cman/qdisk/Makefile	2007-08-26 07:10:30.000000000 +0200
> @@ -13,7 +13,7 @@
>  include ../../make/defines.mk
>  
>  CFLAGS += -D_GNU_SOURCE
> -CFLAGS += -Werror -Wstrict-prototypes -Wshadow -g
> +CFLAGS += -Werror -Wstrict-prototypes -Wshadow
>  CFLAGS += -I${ccsincdir} -I${cmanincdir}
>  CFLAGS += -I.
>  CFLAGS += -I${incdir}

-DDEBUG is usually done by developers and is normally "printf" sort of
run-time debugging.

In my mind, for most distributors, -g always needs to be done, even w/o
-DDEBUG in order for support personnel to able to look at core files.

ACK if you've got a super easy to add CFLAGS, which it looks like you
do:

   ./configure --extracflags="-g" 

Once your patch is applied, I'll look at the stuff in rgmanager that
croaks with --debug enabled.

-- Lon


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]