[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] [GFS2 PATCH] inode size inconsistency



This should have been part of the NFS patch #1 but somehow I missed it when packaging the patches. It is not a critical issue as the others (I hope). RHEL 5.1 31.el5 kernel runs fine without this change.

Our truncate code is chopped into two parts, one for vfs inode changes (in vmtruncate()) and one of gfs inode (in gfs2_truncatei()). These two operatons are, unfortunately, not atomic. So it could happens that vmtruncate() succeeds (inode->i_size is changed) but gfs2_truncatei fails (say kernel temporarily out of memory). This would leave gfs inode i_di.di_size out of sync with vfs inode i_size. It will later confuse gfs2_commit_write() if a write is issued. Last time I checked, it will cause file corruption.

-- Wendy

 Signed-off-by: S. Wendy Cheng <wcheng redhat com>

 ops_inode.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- gfs2-nfs2/fs/gfs2/ops_inode.c	2007-06-23 01:24:22.000000000 -0400
+++ gfs2-nfs/fs/gfs2/ops_inode.c	2007-06-27 10:45:57.000000000 -0400
@@ -903,8 +903,8 @@ static int setattr_size(struct inode *in
 	}
 
 	error = gfs2_truncatei(ip, attr->ia_size);
-	if (error)
-		return error;
+	if (error && (inode->i_size != ip->i_di.di_size))
+		i_size_write(inode, ip->i_di.di_size);
 
 	return error;
 }

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]