[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] cluster/cman/daemon ais.c



Patrick,

Ignore my last comments.

This change was made for the Solaris port.  There appears to be some
problem with using unsigned char for strings on that platform.

Regards
-steve

On Thu, 2007-05-03 at 19:30 -0700, Steven Dake wrote:
> Patrick,
> 
> openais trunk is broken in this regard.  The type should be unsigned
> char.
> 
> Please revert this change - i'll update trunk with the proper typing.
> 
> Regards
> -steve
> 
> On Thu, 2007-05-03 at 12:18 +0000, pcaulfield sourceware org wrote:
> > CVSROOT:	/cvs/cluster
> > Module name:	cluster
> > Changes by:	pcaulfield sourceware org	2007-05-03 12:18:02
> > 
> > Modified files:
> > 	cman/daemon    : ais.c 
> > 
> > Log message:
> > 	Change unsigned char* to char* for compatibility with openais trunk.
> > 
> > Patches:
> > http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/daemon/ais.c.diff?cvsroot=cluster&r1=1.46&r2=1.47
> > 
> > --- cluster/cman/daemon/ais.c	2006/12/18 09:37:45	1.46
> > +++ cluster/cman/daemon/ais.c	2007/05/03 12:18:02	1.47
> > @@ -134,7 +134,7 @@
> >   * Exports the interface for the service
> >   */
> >  static struct openais_service_handler cman_service_handler = {
> > -	.name		    		= (unsigned char *)"openais CMAN membership service 2.01",
> > +	.name		    		= (char *)"openais CMAN membership service 2.01",
> >  	.id			        = CMAN_SERVICE,
> >  	.flow_control			= OPENAIS_FLOW_CONTROL_NOT_REQUIRED,
> >  	.lib_exit_fn		       	= cman_exit_fn,
> > 
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]