[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH][GFS2] Given device ID rather than s_id in "id" sysfs file



On Fri, Nov 02, 2007 at 09:37:15AM -0500, Bob Peterson wrote:
> Hi,
> 
> This patch changes the /sys/fs/gfs2/<s_id>/id file to give the device
> id "major:minor" rather than the s_id.  That enables gfs2_tool to
> match devices properly (by id, not name) when locating the tuning files.

We have to be extremely cautious when changing the kernel abi like this;
have you verified that it doesn't break any existing programs?

> 
> Regards,
> 
> Bob Peterson
> --
> Signed-off-by: Bob Peterson <rpeterso redhat com>
> --
>  fs/gfs2/sys.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
> index 06e0b77..10807b7 100644
> --- a/fs/gfs2/sys.c
> +++ b/fs/gfs2/sys.c
> @@ -32,7 +32,8 @@ spinlock_t gfs2_sys_margs_lock;
>  
>  static ssize_t id_show(struct gfs2_sbd *sdp, char *buf)
>  {
> -	return snprintf(buf, PAGE_SIZE, "%s\n", sdp->sd_vfs->s_id);
> +	return snprintf(buf, PAGE_SIZE, "%u:%u\n",
> +			MAJOR(sdp->sd_vfs->s_dev), MINOR(sdp->sd_vfs->s_dev));
>  }
>  
>  static ssize_t fsname_show(struct gfs2_sbd *sdp, char *buf)
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]