[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] [PATCH] Hard encode paths to (u)mount.gfs*



Hi guys,

given the very nature of mount(8) api to look only in /sbin for (u)mount
helpers, we can hard encode the install paths for our tools into the Makefile
systems. I have never seen anywhere a different behavior in any Linux
distribution and it will make packagers life simpler.

If there are no objections, I will apply the patch.

Fabio

-- 
I'm going to make him an offer he can't refuse.
Index: gfs/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- gfs/Makefile	29 Aug 2007 03:09:54 -0000	1.12
+++ gfs/Makefile	12 Nov 2007 13:11:28 -0000
@@ -24,10 +24,10 @@
 		${MAKE} -C $$i $@; \
 	done; \
 	if [ "$@" = "install" ]; then \
-		cd ${sbindir}; \
+		cd /sbin; \
 			ln -sf mount.gfs2 mount.gfs; \
 			ln -sf umount.gfs2 umount.gfs; \
 	fi; \
 	if [ "$@" = "uninstall" ]; then \
-		cd ${sbindir}; rm -f mount.gfs umount.gfs; \
+		cd /sbin; rm -f mount.gfs umount.gfs; \
 	fi
Index: gfs2/mount/Makefile
===================================================================
RCS file: /cvs/cluster/cluster/gfs2/mount/Makefile,v
retrieving revision 1.18
diff -u -r1.18 Makefile
--- gfs2/mount/Makefile	28 Aug 2007 04:35:44 -0000	1.18
+++ gfs2/mount/Makefile	12 Nov 2007 13:11:29 -0000
@@ -41,11 +41,10 @@
 	$(CC) $(CFLAGS) -c -o $@ $<
 
 install: all
-	install ${TARGET1} ${sbindir}
-	install ${TARGET2} ${sbindir}
+	install ${TARGET1} ${TARGET2} /sbin
 
 uninstall:
-	${UNINSTALL} ${TARGET1} ${TARGET2} ${sbindir}
+	${UNINSTALL} ${TARGET1} ${TARGET2} /sbin
 
 clean:
 	rm -f *.o ${TARGET1} ${TARGET2}

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]