[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] [PATCH] Fix qdiskd device scanning logic



Hi Lon,

the original idea of scanning /dev was not too bad but after porting it to
ocfs2-tools and brainstorming again with the guys, we found a few things that
could be done better.

Let's change a direct scan of /dev into:

- scan /sys/block first for well.. block devices.
- sysfs exports enough info for us to filter out removable devices
  like cdroms that we don't care to even check and to gather
  maj/min of each device.
- scan /dev only to match maj/min and gather the device name.
- never dig or attempt to check hidden files.

Please review or apply.

Joel: once applied on top, this is basically the same code that would land
in ocfs2-tools.

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.

Attachment: fix_proc_part_scan.diff
Description: application/pgp-encrypted


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]