[Cluster-devel] cluster/group/gfs_controld plock.c

[teigland at sourceware.org]

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	teigland at sourceware.org	2007-11-29 21:27:58

Modified files:
	group/gfs_controld: plock.c 

Log message:
	Testing revealed a couple more races I hadn't expected.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/gfs_controld/plock.c.diff?cvsroot=cluster&r1=1.34&r2=1.35

--- cluster/group/gfs_controld/plock.c	2007/11/28 20:49:08	1.34
+++ cluster/group/gfs_controld/plock.c	2007/11/29 21:27:58	1.35
@@ -1404,8 +1404,12 @@
 	}
 
 	if (r->owner != 0) {
-		/* shouldn't happen */
-		log_error("receive_drop from %d r %llx owner %d", from,
+		/* - A sent drop, B sent drop, receive drop A, C sent own,
+		     receive drop B (this warning on C, owner -1)
+	   	   - A sent drop, B sent drop, receive drop A, A sent own,
+		     receive own A, receive drop B (this warning on all,
+		     owner A) */
+		log_debug("receive_drop from %d r %llx owner %d", from,
 			  (unsigned long long)r->number, r->owner);
 		return;
 	}