[Cluster-devel] [PATCH 18/51] [GFS2] better code for translating characters

swhiteho at redhat.com swhiteho at redhat.com
Thu Oct 4 08:49:11 UTC 2007


From: Denis Cheng <crquan at gmail.com>

the original code could work, but I think this code could work better.

Signed-off-by: Denis Cheng <crquan at gmail.com>
Signed-off-by: Steven Whitehouse <swhiteho at redhat.com>

diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 25cfab9..6c820cb 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -144,7 +144,8 @@ static int init_names(struct gfs2_sbd *sdp, int silent)
 	snprintf(sdp->sd_proto_name, GFS2_FSNAME_LEN, "%s", proto);
 	snprintf(sdp->sd_table_name, GFS2_FSNAME_LEN, "%s", table);
 
-	while ((table = strchr(sdp->sd_table_name, '/')))
+	table = sdp->sd_table_name;
+	while ((table = strchr(table, '/')))
 		*table = '_';
 
 out:
-- 
1.5.1.2




More information about the Cluster-devel mailing list