[Cluster-devel] [PATCH 20/51] [GFS2] fixed a NULL pointer assignment BUG

swhiteho at redhat.com swhiteho at redhat.com
Thu Oct 4 08:49:13 UTC 2007


From: Denis Cheng <crquan at gmail.com>

Signed-off-by: Denis Cheng <crquan at gmail.com>
Signed-off-by: Steven Whitehouse <swhiteho at redhat.com>

diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 6c820cb..c1c6672 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -292,8 +292,9 @@ static int init_sb(struct gfs2_sbd *sdp, int silent, int undo)
 		fs_err(sdp, "can't get root dentry\n");
 		error = -ENOMEM;
 		iput(inode);
-	}
-	sb->s_root->d_op = &gfs2_dops;
+	} else
+		sb->s_root->d_op = &gfs2_dops;
+	
 out:
 	gfs2_glock_dq_uninit(&sb_gh);
 	return error;
-- 
1.5.1.2




More information about the Cluster-devel mailing list