[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] Clean up top level configure part 1



Fabio Massimo Di Nitto wrote:
> Hi guys,
> 
> the patch in attachment is purely cosmetic. I switched the top level configure
> to use perl -w rather than just perl and spotted a bunch of warnings.
> 
> This patch:
> 
> - switches permanently to perl -w
> - fixes all the warnings in the script.
> 
> Part1 because I plan to re-rewrite the top level configure from scratch by using
> the only known thing in every system (that being /bin/sh) and make path to perl
> configurable (not all system use /usr/bin/perl).
> I also plan to kill the need of make/defines.mk.input and create make/define.mk
> directly.
>

You missed one:

-- 
Patrick
Index: configure
===================================================================
RCS file: /cvs/cluster/cluster/configure,v
retrieving revision 1.32
diff -u -p -r1.32 configure
--- configure	19 Sep 2007 11:07:21 -0000	1.32
+++ configure	24 Sep 2007 13:45:06 -0000
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!/usr/bin/perl -w
 
 ###############################################################################
 ###############################################################################
@@ -124,7 +124,7 @@ if(!$err) {
 # Check for the --help flag
 if ($help || !$err) {
   $_ = $0;
-  s/.*\.\/(.*)/\1/;
+  s/.*\.\/(.*)/$1/;
   print "Usage: $_ [flags]\n";
   print "--help\t\tPrints this usage information\n\n";
   print "install flags:\n";
@@ -192,6 +192,9 @@ if (!$cflags) {
 if ($extracflags) {
   $cflags="${cflags} ${extracflags}";
 }
+if (!$ldflags) {
+  $ldflags="";
+}
 if ($extraldflags) {
   $ldflags="${ldflags} ${extraldflags}";
 }
@@ -308,6 +311,46 @@ if (!$sbindir) {
 if (!$sharedir) {
   $sharedir="${prefix}/share/cluster";
 }
+if (!$fence_agents) {
+  $fence_agents="all";
+}
+if (!$without_ccs) {
+  $without_ccs="";
+}
+if (!$without_cman) {
+  $without_cman="";
+}
+if (!$without_dlm) {
+  $without_dlm="";
+}
+if (!$without_group) {
+  $without_group="";
+}
+if (!$without_fence) {
+  $without_fence="";
+}
+if (!$without_gfs) {
+  $without_gfs="";
+}
+if (!$without_gfs2) {
+  $without_gfs2="";
+}
+if (!$without_gnbd) {
+  $without_gnbd="";
+}       
+if (!$without_rgmanager) {
+  $without_rgmanager="";
+}
+if (!$release_major) {
+  $release_major="";
+}
+if (!$release_minor) {
+  $release_minor="";
+}
+if (!$enable_xen) {
+  $enable_xen="";
+}
+
 
 @args = "find fence/agents -mindepth 2 -maxdepth 2 -name Makefile -printf '%h'";
 open (IFILE, "@args |");
@@ -318,12 +361,12 @@ while (<IFILE>) {
 }
 close IFILE;
 
-if ($fence_agents eq help) {
+if ($fence_agents eq "help") {
   print "Available fence agents:\n$all_fence\n";
   exit 0;
 }
 
-if ((!$fence_agents) || ($fence_agents eq all)) {
+if ((!$fence_agents) || ($fence_agents eq "all")) {
   print "\nThe following fence agents will be build on this system:\n$all_fence\n";
   print "\nNOTE: xvm will build only if --enable_xen has been specified\n\n";
   $fence_agents = $all_fence

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]