[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] [PATCH] gfs2_fsck: Fix undefined operation warnings



Occurrences of *ptr++ made gcc throw up "operation on 'ptr' may be
undefined" warnings. This patch adds parentheses to make the order of evaluation
explicit.

Signed-off-by: Andrew Price <andy andrewprice me uk>
---
 gfs2/fsck/fs_recovery.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gfs2/fsck/fs_recovery.c b/gfs2/fsck/fs_recovery.c
index 3b25dc6..573152e 100644
--- a/gfs2/fsck/fs_recovery.c
+++ b/gfs2/fsck/fs_recovery.c
@@ -125,7 +125,7 @@ static int buf_lo_scan_elements(struct gfs2_inode *ip, unsigned int start,
 
 		sd_found_metablocks++;
 
-		blkno = be64_to_cpu(*ptr++);
+		blkno = be64_to_cpu((*ptr)++);
 		if (gfs2_revoke_check(sdp, blkno, start))
 			continue;
 
@@ -218,8 +218,8 @@ static int databuf_lo_scan_elements(struct gfs2_inode *ip, unsigned int start,
 
 	gfs2_replay_incr_blk(ip, &start);
 	for (; blks; gfs2_replay_incr_blk(ip, &start), blks--) {
-		blkno = be64_to_cpu(*ptr++);
-		esc = be64_to_cpu(*ptr++);
+		blkno = be64_to_cpu((*ptr)++);
+		esc = be64_to_cpu((*ptr)++);
 
 		sd_found_jblocks++;
 
-- 
1.5.4.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]