[Cluster-devel] Re: [PATCH 1/2] NLM failover unlock commands

Wendy Cheng wcheng at redhat.com
Wed Jan 9 03:49:17 UTC 2008


Christoph Hellwig wrote:

>>+/* cluster failover support */
>>+
>>+typedef struct {
>>+	int     cmd;
>>+	int     stat;
>>+	int     gp;
>>+	void    *datap;
>>+} nlm_fo_cmd;
>>    
>>
>
>please don't introduce typedefs for struct types.
>  
>

I don't do much community version of linux code so its coding standard 
is new to me. Any reason for this (not doing typedefs) ?

-- Wendy




More information about the Cluster-devel mailing list