[Cluster-devel] cluster/gfs-kernel/src/dlm group.c
teigland at sourceware.org
teigland at sourceware.org
Mon Jan 14 15:29:43 UTC 2008
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: teigland at sourceware.org 2008-01-14 15:29:43
Modified files:
gfs-kernel/src/dlm: group.c
Log message:
bz 353311
Disassembling the module, the oops appears to be when dereferencing
dlm->mg_nodes. I see one place where the mg_nodes list is modified
without holding mg_nodes_lock, and that's in release_mg_nodes().
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/dlm/group.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.8.2.2&r2=1.8.2.3
--- cluster/gfs-kernel/src/dlm/Attic/group.c 2005/06/29 07:28:21 1.8.2.2
+++ cluster/gfs-kernel/src/dlm/Attic/group.c 2008/01/14 15:29:42 1.8.2.3
@@ -751,7 +751,9 @@
kcl_unregister_service(dlm->mg_local_id);
release_jid(dlm);
+ down(&dlm->mg_nodes_lock);
release_mg_nodes(dlm);
+ up(&dlm->mg_nodes_lock);
}
/*
More information about the Cluster-devel
mailing list