[Cluster-devel] Re: [PATCH 2/3] NLM per-ip grace period - core

[J. Bruce Fields]

On Tue, Jan 29, 2008 at 11:33:08AM -0500, Chuck Lever wrote:
> On Jan 28, 2008, at 9:56 PM, J. Bruce Fields wrote:
>> Also, is that the right choice of types?  Maybe we should just use
>> struct in6_addr?
>
> I agree with Bruce -- just use in_addr, and leave out the unused IPv6  
> stuff for now.
>
> In some places, we just replace in_addr with in6_addr and simply map  
> IPv4 to IPv6 addresses, rather than setting up a union.
>
> If the address is used as a hash and never displayed, using a mapped  
> IPv4 address is sufficient, and keeps things simple.
>
>> +
>>  int
>>  nlmsvc_failover_setgrace(void *server_ip, int ip_size)
>
> Should this be
>
>   int nlmsvc_failover_setgrace(const struct in_addr *server_ip)
>
> for now, and later we can change it to use in6_addr instead?

I could go either way, If it'd be just as easy to use in6_addr's
internally everywhere from the start, that'd be great, and then it'll be
easy enough to tack the ipv6 parsing onto the interfaces later.

But I'd leave that to Wendy's judgement for now--I think it's reasonable
to keep it ipv4 only for now if that keeps the initial implementation
simpler.

(Just drop the union and use in_addr or in6_addr as opposed to the
home-grown types.)

--b.