[Cluster-devel] [PATCH] Fix libdlm static build

Fabio M. Di Nitto fdinitto at redhat.com
Thu Jul 3 17:49:59 UTC 2008


On Thu, 3 Jul 2008, Christine Caulfield wrote:

> Fabio M. Di Nitto wrote:
>> 
>> Hi David,
>> 
>> the objects included in the static version of dlm are different from the 
>> one in the shared lib. This is generally wrong as they should be the same.
>> 
>> the patch addresses the problem by killing .po files in favour of more 
>> common .o and changing the linking targets.
>> 
>> the patch applies to both master and stable2. rhel branches are also 
>> affected by other problems (_lt is linked to pthread) but i don't think 
>> it's wise to change it.
>> 
>> Please review and apply.
>> 
>> Thanks
>> Fabio
>>

[SNIP]

> I don't understand the problem you are trying to fix here.

To have the same objects in both.

> Having PIC objects 
> in the dynamic library and non-PIC in the static is perfectly standard 
> practice.

Why does dlm needs to have it different from the rest of our libraries? Is 
there a special reason?

Fabio

--
I'm going to make him an offer he can't refuse.




More information about the Cluster-devel mailing list