[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] Cluster Project branch, master, updated. cluster-2.99.05-66-g0dcc5e5



On Fri, 11 Jul 2008, teigland sourceware org wrote:

- Log -----------------------------------------------------------------
commit 0dcc5e557008df4d51aef891ebfb998a34785f04
Author: David Teigland <teigland redhat com>
Date:   Fri Jul 11 12:04:26 2008 -0500

   fenced: tune logsys settings

   put errors in fenced.log (in addition to syslog) by default
   keep debug out of syslog by default (commented out pending openais commit)

   Signed-off-by: David Teigland <teigland redhat com>

-----------------------------------------------------------------------

Summary of changes:
fence/fenced/logging.c |    8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/fence/fenced/logging.c b/fence/fenced/logging.c
index 485810d..1cfb03e 100644
--- a/fence/fenced/logging.c
+++ b/fence/fenced/logging.c
@@ -1,6 +1,12 @@
#include "fd.h"

-#define DEFAULT_MODE		LOG_MODE_OUTPUT_SYSLOG_THREADED
+/* default: errors go to syslog (/var/log/messages) and fenced.log
+   logging/debug=on: errors continue going to syslog (/var/log/messages)
+   and fenced.log, debug messages are added to fenced.log. */
+
+#define DEFAULT_MODE		LOG_MODE_OUTPUT_SYSLOG_THREADED | \
+				LOG_MODE_NOSUBSYS | \

isn't LOG_MODE_NOSUBSYS going to remove [FENCED] from the output?

How are we going to recognize our messages in syslog?

My understading was that NOSUBSYS should be used to print to stderr only

+				LOG_MODE_OUTPUT_FILE /* | LOG_MODE_NO_DEBUG_SYSLOG */

LOG_MODE_FILTER_DEBUG_FROM_SYSLOG <- after Steven/Chrissie review.

Fabio

--
I'm going to make him an offer he can't refuse.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]