[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH/RFC] Standardize on /etc/sysconfig/cluster for init script



On Wed, Jul 30, 2008 at 11:01:07AM -0500, David Teigland wrote:
> On Mon, Jul 28, 2008 at 10:20:49AM +0200, Fabio M. Di Nitto wrote:
> > I just noticed that we have a very inconsistent way to set init script 
> > defaults by using /etc/sysconfig/{cman,cluster,scsi_reserve}.
> > 
> > the patch in attachment is very simple and standardize everything to 
> > /etc/sysconfig/cluster and retains backward compatibility.
> > 
> > Please ACK or i will apply.
> 
> Doesn't it make most sense for the name of the sysconfig file to match the
> name of the init script it corresponds to?  i.e. the config file for
> init.d/cman would be sysconfig/cman?

	They should absolutely match the init script.  I could perhaps
seen an exception for something everything includes, but then I would
have the other sysconfig files include it.  What do I mean?  Say you
have a sysconfig/cluster file you want everything to see (cman,
fs_controld, etc).  You would have sysconfig/cman source
sysconfig/cluster.  That way, someone reading sysconfig/cman would see
it.  I would think we want to avoid folks having to read the init script
to find the config files.
	Btw, let's all remember that 'sysconfig' is spelled 'default' on
debian/ubuntu, so be aware of that in your scripts :-)

Joel

-- 

Life's Little Instruction Book #335

	"Every so often, push your luck."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel becker oracle com
Phone: (650) 506-8127


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]