[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] Cluster Project branch, STABLE2, updated. cluster-2.03.02-7-ga6b6a30



Hi,

It might be a silly question, but this looks to me like trying to fix a
kernel bug by adding a userland one. Why not simply update the kernel to
return the correct value?

Steve.

On Tue, 2008-05-13 at 19:08 +0000, teigland sourceware org wrote:
> This is an automated email from the git hooks/post-receive script. It was
> generated because a ref change was pushed to the repository containing
> the project "Cluster Project".
> 
> http://sources.redhat.com/git/gitweb.cgi?p=cluster.git;a=commitdiff;h=a6b6a30358fd5e247a37e2fe493ef6a683174b66
> 
> The branch, STABLE2 has been updated
>        via  a6b6a30358fd5e247a37e2fe493ef6a683174b66 (commit)
>       from  edd597845e68e9826907ec1e23692e1fc394e9a4 (commit)
> 
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email; so we list those
> revisions in full, below.
> 
> - Log -----------------------------------------------------------------
> commit a6b6a30358fd5e247a37e2fe493ef6a683174b66
> Author: David Teigland <teigland redhat com>
> Date:   Tue May 13 14:04:51 2008 -0500
> 
>     gfs_controld: ignore write(2) return value on plock dev
>     
>     bz 446128
>     
>     When plocks originate from nfs clients, the kernel mistakenly
>     returns 0 instead of the number of bytes written to the plock
>     device on write(2).  Don't spam /var/log/messages with errors
>     reporting a bad return value from write(2).
>     
>     Signed-off-by: David Teigland <teigland redhat com>
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  group/gfs_controld/plock.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/group/gfs_controld/plock.c b/group/gfs_controld/plock.c
> index 42890df..beedf42 100644
> --- a/group/gfs_controld/plock.c
> +++ b/group/gfs_controld/plock.c
> @@ -771,12 +771,8 @@ static int add_waiter(struct mountgroup *mg, struct resource *r,
>  static void write_result(struct mountgroup *mg, struct gdlm_plock_info *in,
>  			 int rv)
>  {
> -	int err;
> -
>  	in->rv = rv;
> -	err = write(control_fd, in, sizeof(struct gdlm_plock_info));
> -	if (err != sizeof(struct gdlm_plock_info))
> -		log_error("plock result write err %d errno %d", err, errno);
> +	write(control_fd, in, sizeof(struct gdlm_plock_info));
>  }
>  
>  static void do_waiters(struct mountgroup *mg, struct resource *r)
> 
> 
> hooks/post-receive
> --
> Cluster Project
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]