[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] Cluster Project branch, master, updated. cluster-2.99.02-27-gd1d2954




Hi Ryan,

On Wed, 28 May 2008, rmccabe sourceware org wrote:

- Log -----------------------------------------------------------------
commit d1d29545d7efeefbe4cd540bdd3dfd248d2310c0
Author: Ryan McCabe <rmccabe redhat com>
Date:   Wed May 28 16:30:42 2008 -0400

   libfence: update copyright notice

   - Clarify copyright notice so that GPLv2 is specified explicitly.

Is there any reason why it's not LGPL? I thought all our shared libraries should be LGPL to make life simpler for other people to use...

   - Use the full path to ssh and telnet when executing the binaries.

It's generally better to avoid harcoding paths if we can avoid it. Custom builds would require extra patching if for example ssh is in /usr/local/bin..

diff --git a/fence/agents/lib/fencing.py.py b/fence/agents/lib/fencing.py.py
index 944553c..300183a 100644
--- a/fence/agents/lib/fencing.py.py
+++ b/fence/agents/lib/fencing.py.py
@@ -10,9 +10,9 @@ import telnetlib

## do not add code here.
#BEGIN_VERSION_GENERATION
-RELEASE_VERSION="New fence lib agent - test release on steroids"
-REDHAT_COPYRIGHT=""
-BUILD_DATE="March, 2008"
+RELEASE_VERSION = "New fence lib agent - test release on steroids"
+REDHAT_COPYRIGHT = ""
+BUILD_DATE = "March, 2008"
#END_VERSION_GENERATION

This change is not respected by the Makefile system. Everything between #BEGIN and #END is virtually ignored. Do we need to respect this spacing?
If so, i will just change the build system to do it.

Thanks
Fabio

--
I'm going to make him an offer he can't refuse.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]