[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] Re: Groupd uevent clean up



On Tue, Nov 25, 2008 at 04:44:32PM +0000, Steven Whitehouse wrote:
> > OK, thanks, I dislike the const sprinkling, and I don't care about string
> Whats wrong with adding the consts? It seems to make sense to mark the
> fsname as const since its just being used as a key for looking up the
> mg.

The PITA factor outweighs it's advantages, at least in the code I have to
maintain myself.

> My dev machine currently has a strange mix of F-9 and (old) rawhide
> packages on it, so that installing the required bits of openais to build
> isn't so easy. If you are able to run a quick test, that would be
> helpful otherwise, I'll look for another place to build it for testing.

I'll test a new patch that's limited to the parsing change.

> I've just noticed dlm_controld has this same bug,

Fixed that one too.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]