[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 2/4] gfs2_quota: Fix sparse error



----- "Andrew Price" <andy andrewprice me uk> wrote:
| Fix sparse error "marked inline, but without a definition" and make
| write_quota_internal static as it's only used in main.c
| 
| Signed-off-by: Andrew Price <andy andrewprice me uk>
| ---
|  gfs2/quota/gfs2_quota.h |    4 +---
|  gfs2/quota/main.c       |    4 ++--
|  2 files changed, 3 insertions(+), 5 deletions(-)
| 
| diff --git a/gfs2/quota/gfs2_quota.h b/gfs2/quota/gfs2_quota.h
| index 462246f..f15c25b 100644
| --- a/gfs2/quota/gfs2_quota.h
| +++ b/gfs2/quota/gfs2_quota.h
| @@ -66,10 +66,8 @@ void cleanup(void);
|  void read_superblock(struct gfs2_sb *sb, struct gfs2_sbd *sdp);
|  void get_last_quota_id(int fd, uint32_t *max_id);
|  int is_valid_quota_list(int fd);
| -inline void read_quota_internal(int fd, unsigned int id, int id_type,
| 
| +void read_quota_internal(int fd, unsigned int id, int id_type,
|  				struct gfs2_quota *q);
| -inline void write_quota_internal(int fd, unsigned int id, int
| id_type, 
| -				 struct gfs2_quota *q);
|  void print_quota_list_warning(void);
|  
|  /*  check.c  */
| diff --git a/gfs2/quota/main.c b/gfs2/quota/main.c
| index 16692dd..f80313d 100644
| --- a/gfs2/quota/main.c
| +++ b/gfs2/quota/main.c
| @@ -308,7 +308,7 @@ read_superblock(struct gfs2_sb *sb, struct
| gfs2_sbd *sdp)
|  	close(fd);
|  }
|  
| -inline void 
| +void
|  read_quota_internal(int fd, uint32_t id, int id_type, struct
| gfs2_quota *q)
|  {
|  	/* seek to the appropriate offset in the quota file and read the 
| @@ -331,7 +331,7 @@ read_quota_internal(int fd, uint32_t id, int
| id_type, struct gfs2_quota *q)
|  	gfs2_quota_in(q, buf);
|  }
|  
| -inline void 
| +static inline void
|  write_quota_internal(int fd, uint32_t id, int id_type, struct
| gfs2_quota *q)
|  {
|  	/* seek to the appropriate offset in the quota file and read the
| -- 
| 1.6.3.3
Hi,

ACKed by Bob Peterson <rpeterso redhat com>

Regards,

Bob Peterson
Red Hat File Systems


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]