[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 3/4] libgfs2: Fix "Value stored is never read" warnings



----- "Andrew Price" <andy andrewprice me uk> wrote:
| Building with CC="clang --analyze" gave the following warnings:
| 
| - misc.c:126:8: warning: Although the value stored to 'ret' is used
| in
|   the enclosing expression, the value is never actually read from
| 'ret'
| - fs_geometry.c:82:3: warning: Value stored to 'rgsize_specified' is
|   never read
| - gfs1.c:308:3: warning: Value stored to 'f' is never read
| 
| This patch makes them go away.
| 
| Signed-off-by: Andrew Price <andy andrewprice me uk>
| ---
(snip)
| +		if (6 != ret)
Hi,

I prefer the form "if (ret != 6)" but this will work.
ACKed by Bob Peterson <rpeterso redhat com>

Regards,

Bob Peterson
Red Hat File Systems


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]