[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] Re: [PATCH] GFS2: jumping to wrong label?



Hi,

Thanks for spotting & fixing that. Now in the -nmw git tree. Thanks,

Steve.

On Sat, 2009-08-22 at 19:26 +0200, Roel Kluin wrote:
> Also a gfs2_glock_dq() is required here.
> 
> Signed-off-by: Roel Kluin <roel kluin gmail com>
> ---
> I found this by static code analysis, Is it correct? please review.
> 
> diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> index f8bd20b..ce551f8 100644
> --- a/fs/gfs2/ops_inode.c
> +++ b/fs/gfs2/ops_inode.c
> @@ -349,7 +349,7 @@ static int gfs2_unlink(struct inode *dir, struct dentry *dentry)
>  
>  	error = gfs2_trans_begin(sdp, 2*RES_DINODE + RES_LEAF + RES_RG_BIT, 0);
>  	if (error)
> -		goto out_rgrp;
> +		goto out_gunlock;
>  
>  	error = gfs2_dir_del(dip, &dentry->d_name);
>          if (error)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]