[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] dlm: Allow large nodeids



David Teigland wrote:
> On Wed, Jan 28, 2009 at 11:27:35AM +0000, Chrissie Caulfield wrote:
>> David Teigland wrote:
>>> On Tue, Jan 27, 2009 at 02:06:30PM -0600, David Teigland wrote:
>>>> On Tue, Jan 27, 2009 at 11:33:30AM +0000, Chrissie Caulfield wrote:
>>>>> This an updated patch that uses hlists rather than list_heads to save
>>>>> memory in the connection structure.
> 
> This patch (with fix) seems to cause the following about half of the time when
> killing dlm_controld:
> 

Oops, Something slightly vital was missing from free_conn() ...


Chrissie
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index 6025669..a3114f5 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -1433,6 +1433,7 @@ static void free_conn(struct connection *con)
 	close_connection(con, true);
 	if (con->othercon)
 		kmem_cache_free(con_cache, con->othercon);
+	hlist_del(&con->list);
 	kmem_cache_free(con_cache, con);
 }
 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]