[Cluster-devel] Re: Clean up & fixes for master branch of gfs_controld

[David Teigland]

On Mon, Oct 12, 2009 at 10:31:40AM +0100, Steven Whitehouse wrote:
> Hi,
> 
> The following patch cleans up some old code in gfs_controld and also fixes
> one or two issues along the way. After this patch has been applied,
> gfs_controld no longer reads from sysfs, but instead gathers all its
> information from the uevents. The uevents in question have been in all
> recent versions of GFS & GFS2 and so there should be no backward
> compatibility issues (even so, this is for the master branch only, at
> least at the moment).
> 
> The diffstat shows a net reduction of about 100 lines of code.
> 
>  group/gfs_controld/cpg-new.c    |  161 ++++++++++++++--------------------------
>  group/gfs_controld/gfs_daemon.h |    6 -
>  group/gfs_controld/main.c       |   99 ++++++++++--------------
>  group/gfs_controld/util.c       |   43 ----------
>  4 files changed, 106 insertions(+), 203 deletions(-)

Looks good, thanks.
Dave