[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] GFS2: Improve statfs and quota usability



Hi,

On Tue, 2009-10-13 at 09:49 -0500, Benjamin Marzinski wrote:
> GFS2 now has three new mount options, statfs_quantum, quota_quantum and
> statfs_percent.  statfs_quantum and quota_quantum simply allow you to set the
> tunables of the same name.  Setting setting statfs_quantum to 0 will
> also turn on the statfs_slow tunable.  statfs_percent is both a mount option
> and a tunable.  It accepts an integer between 0 and 100.  Numbers between 1 and 
> 100 will cause GFS2 to do any early sync when the local number of blocks free
> changes by at least statfs_percent from the totoal number of blocks free.
> Setting statfs_percent to 0 disables this.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins redhat com>
> ---
>  fs/gfs2/incore.h     |    5 ++++
>  fs/gfs2/ops_fstype.c |   15 ++++++++++---
>  fs/gfs2/quota.c      |   21 ++++++++++++++++---
>  fs/gfs2/quota.h      |    2 +
>  fs/gfs2/super.c      |   56 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  fs/gfs2/sys.c        |   33 +++++++++++++++++-------------
>  6 files changed, 112 insertions(+), 20 deletions(-)
> 
Can you drop out the bit adding the new sysfs file? The plan is to
reduce those in favour of using mount options as much as possible. Other
than that, it looks good to me.

When we update the docs we should add something to ensure that people
realise that setting the options via the mount command line is the
preferred method,

Steve.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]