[Cluster-devel] Re: [RFC PATCH] dlm: enhancing dlm_controld (pcmk) to be able to handle redundant rings

[Andrew Beekhof]

Looks good to me :-)
Although it might be nice to have the automated detection in place too.

Less things for the admin to get wrong.  What do you think Dave?

On Thu, Oct 15, 2009 at 7:34 AM, Jiaju Zhang <jjzhang.linux at gmail.com> wrote:
>
>
> On Thu, Oct 15, 2009 at 2:17 AM, David Teigland <teigland at redhat.com> wrote:
>>
>> On Wed, Oct 14, 2009 at 06:50:56PM +0800, Jiaju Zhang wrote:
>> > Hi,
>> >
>> > Since there is no proper way to enable SCTP when using pacemaker stack,
>> > this patch is to auto-enabled SCTP when redundant rings have been
>> > configured
>> > in corosync.
>> > Review and comments are welcome :)
>>
>> Hi,
>>
>> Could we just make it a command line option?  Is it important to turn on
>> automatically?
>>
>
> Yes, making it a command line option also works fine and it is simpler than
> that patch. Attached is a new patch which adding a command line option, I'll
> be very appreciated for your review and comments.
>
> The reason I wanted to turn on SCTP automatically is that it might have a
> little better usability since the user won't care the detail "redundant
> rings need SCTP to be configured" and even if the user hasn't read the
> manual very carefully and hasn't turn on SCTP in command line, the software
> will also help him to do this.
> That was my original thought, I don't know which one is better at that time.
>
> Thanks again for your review of the new patch :)
>
> Signed-off-by: Jiaju Zhang <jjzhang.linux at gmail.com>
> ---
>
>
>
>
>
>