[Cluster-devel] [PATCH 1/8] Add "service" object manipulations

Lon Hohberger lhh at redhat.com
Fri Dec 10 14:49:08 UTC 2010


On Fri, 2010-12-10 at 16:42 +0300, Dmitry Mishin wrote:
> +static xmlNode *find_ip_resource(xmlNode *root, const char *name)
> +{
> +	return do_find_node(root, name, "ip", "name");
> +}
> +

should be

	return do_find_node(root, name, "ip", "address");

IP resources don't have names; the primary attribute is the address
field.  Adding a "name" will break configuration validation without
patches to ip.sh and cluster.rng.

(this might happen in other patches too)

-- Lon




More information about the Cluster-devel mailing list