[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 1/8] Add "service" object manipulations



On Fri, 2010-12-10 at 16:42 +0300, Dmitry Mishin wrote:
> +static xmlNode *find_ip_resource(xmlNode *root, const char *name)
> +{
> +	return do_find_node(root, name, "ip", "name");
> +}
> +

should be

	return do_find_node(root, name, "ip", "address");

IP resources don't have names; the primary attribute is the address
field.  Adding a "name" will break configuration validation without
patches to ip.sh and cluster.rng.

(this might happen in other patches too)

-- Lon


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]