[Cluster-devel] [PATCH] dlm_controld.pcmk: Fix membership change judging issue

[Andrew Beekhof]

On Thu, May 13, 2010 at 10:36 PM, Lars Marowsky-Bree <lmb at novell.com> wrote:
> On 2010-05-13T22:19:58, Andrew Beekhof <andrew at beekhof.net> wrote:
>
>> > ais_dispatch() was moved to update_cluster(). That's safe, it seems.
>> But pointless and unrelated to the problem, so why include it?
>
> I took it that JJ thought this was part of the solution.

ci == ais_async_fd,  if there was something to read we should have
already had a callback.

>
>> Does the behavior still occur with pacemaker 1.1.2?
>
> Yes. Which fix do you think would change this?

These two that I mentioned last week:
  http://hg.clusterlabs.org/pacemaker/1.1/rev/34ae9f7b4675
  http://hg.clusterlabs.org/pacemaker/1.1/rev/19fdc0a3885a

I really doubt the patch is the right fix, conceptually, the node
can't be a member until the crmd process is running and done a whole
heap of processing.
So CRM_NODE_MEMBER without crm_proc_crmd makes no sense.

More likely, as-in the patches above, the process list wasn't being
updated correctly and thats what needs to get fixed.
It just never mattered before.

>
> JJ's patch has been tested and seems to work in general as well as
> address the problem.
>
>
> Regards,
>    Lars
>
> --
> Architect Storage/HA, OPS Engineering, Novell, Inc.
> SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
> "Experience is the name everyone gives to their mistakes." -- Oscar Wilde
>
>