[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] Fixed scripts for use with rgmanager



On 08/11/2011 04:28 AM, Chris Feist wrote:
> 
>>>  12 files changed, 53 insertions(+), 11 deletions(-)
>>>  mode change 100644 => 100755 rgmanager/src/resources/apache.sh
>>>  mode change 100644 => 100755 rgmanager/src/resources/clusterfs.sh
>>>  mode change 100644 => 100755 rgmanager/src/resources/ip.sh
>>>  mode change 100644 => 100755 rgmanager/src/resources/mysql.sh
>>>  mode change 100644 => 100755 rgmanager/src/resources/netfs.sh
>>>  mode change 100644 => 100755 rgmanager/src/resources/nfsclient.sh
>>>  mode change 100644 => 100755 rgmanager/src/resources/nfsserver.sh
>>>  mode change 100644 => 100755
>>>  rgmanager/src/resources/utils/httpd-parse-config.pl
>>
>> Modes didn't need to be changed.
> 
> Modes need to be changed to pass ocf_tester (it's one of the tests), should we just skip this?
> 

It makes sense to be able to test within the source tree too. At the
time those files were set 0644, we had no test and no use case to keep
them executable within the source. Now we do. ACK from me.

The agents are installed 0755 in /usr/share/cluster by Makefile targets.
Can you please cross check if also utils/httpd-parse-config.pl is 0755
once installed? If not we need to fix that in utils/Makefile.am.

Fabio


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]