[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [Patch 12/44] fsck.gfs2: get rid of triple negative logic



Looks good,

Steve.

On Thu, 2011-08-11 at 17:03 -0400, Bob Peterson wrote:
> >From 62d7423184da8e291396cb54269612d501437006 Mon Sep 17 00:00:00 2001
> From: Bob Peterson <rpeterso redhat com>
> Date: Mon, 8 Aug 2011 14:44:46 -0500
> Subject: [PATCH 12/44] fsck.gfs2: get rid of triple negative logic
> 
> This patch changes the logic of the code from being triple-negative
> to single-negative so it won't twist your brain into knots.
> 
> rhbz#675723
> ---
>  gfs2/fsck/metawalk.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
> index f2cd938..a4d7d3e 100644
> --- a/gfs2/fsck/metawalk.c
> +++ b/gfs2/fsck/metawalk.c
> @@ -930,7 +930,7 @@ static int delete_block_if_notdup(struct gfs2_inode *ip, uint64_t block,
>  	uint8_t q;
>  	struct duptree *d;
>  
> -	if (!valid_block(ip->i_sbd, block) != 0)
> +	if (!valid_block(ip->i_sbd, block))
>  		return -EFAULT;
>  
>  	q = block_type(block);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]