[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 2/2] fenced: don't send dbus signals if disabled



On Wed, Feb 02, 2011 at 06:11:30PM -0500, Lon Hohberger wrote:
> On Wed, 2011-02-02 at 17:01 -0600, Ryan O'Hara wrote:
> > This patch checks that dbus signals are not disabled before sending a
> > dbus signal.
> > 
> > Signed-off-by: Ryan O'Hara <rohara redhat com>
> > ---
> >  fence/fenced/recover.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/fence/fenced/recover.c b/fence/fenced/recover.c
> > index 5d7680d..6fdd116 100644
> > --- a/fence/fenced/recover.c
> > +++ b/fence/fenced/recover.c
> > @@ -384,7 +384,9 @@ void fence_victims(struct fd *fd)
> >  		log_error("fence %s %s", node->name,
> >  			  error ? "failed" : "success");
> >  
> > -		dbus_send(node->name, node->nodeid, error);
> > +		if (!optd_disable_dbus) {
> > +		    dbus_send(node->name, node->nodeid, error);
> > +		}
> 
> Indentation style doesn't match Dave's here or in dbus.c
> 
> I approve, but Dave really needs to sign off too.
> 
> -- Lon

Yeah. I fixed the indentation in my local repo. Not planning to post
another patch just for whitespace, unless someone insists.

Thanks for the review.

Ryan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]