[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig



On 1/4/2011 10:00 AM, Jan Friesse wrote:
> Lon,
> even it may "logically" seemed that original code is incorrect and your
> patch make sense, it's not the case.
> 
> Actually, corosync has 3 transports:
> udp, udpu and iba.
> 
> Broadcast is same transport as udp but only has broadcast flag set on.
> 
> In other words, this patch is not correct.
> 

So in order to configure broadcast we still need to use:

<cman transport="udp" broadcast="yes"/> ?

I find that redundant tho...

Cheers
Fabio

> Regards,
>   Honza
> 
> Lon Hohberger wrote:
>> Signed-off-by: Lon Hohberger <lhh redhat com>
>> ---
>>  cman/daemon/cman-preconfig.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/cman/daemon/cman-preconfig.c b/cman/daemon/cman-preconfig.c
>> index 5239d89..5d608a7 100644
>> --- a/cman/daemon/cman-preconfig.c
>> +++ b/cman/daemon/cman-preconfig.c
>> @@ -286,7 +286,7 @@ static int add_ifaddr(struct objdb_iface_ver0 *objdb, char *mcast, char *ifaddr,
>>  	int ret = 0;
>>  	const char *tx_mech_to_str[] = {
>>  		[TX_MECH_UDP] = "udp",
>> -		[TX_MECH_UDPB] = "udp",
>> +		[TX_MECH_UDPB] = "udpb",
>>  		[TX_MECH_UDPU] = "udpu",
>>  		[TX_MECH_RDMA] = "iba",
>>  	};
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]