[Cluster-devel] [PATCH 2/2] mkfs: Change hardcoded numbers by new macro definitions
Carlos Maiolino
cmaiolino at redhat.com
Thu Jul 7 14:22:00 UTC 2011
The verify_arguments() function makes use of some hardcoded
integers that would best fit as macros.
---
gfs2/mkfs/main_mkfs.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/gfs2/mkfs/main_mkfs.c b/gfs2/mkfs/main_mkfs.c
index db2309a..b0bb6e3 100644
--- a/gfs2/mkfs/main_mkfs.c
+++ b/gfs2/mkfs/main_mkfs.c
@@ -332,12 +332,11 @@ static void verify_arguments(struct gfs2_sbd *sdp)
{
if (!sdp->expert)
test_locking(sdp->lockproto, sdp->locktable);
- /* Look at this! Why can't we go bigger than 2GB? */
if (sdp->expert) {
- if (1 > sdp->rgsize || sdp->rgsize > 2048)
+ if (GFS2_EXP_MIN_RGSIZE > sdp->rgsize || sdp->rgsize > GFS2_MAX_RGSIZE)
die( _("bad resource group size\n"));
} else {
- if (32 > sdp->rgsize || sdp->rgsize > 2048)
+ if (GFS2_MIN_RGSIZE > sdp->rgsize || sdp->rgsize > GFS2_MAX_RGSIZE)
die( _("bad resource group size\n"));
}
--
1.7.5.2
More information about the Cluster-devel
mailing list