[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH][fence-agents] fence_eaton_snmp: add support for Eaton Switched ePDU




2011/7/8 Marek Grac <mgrac redhat com>
Hi Arnaud,

Hi Marek,
 
On 07/04/2011 08:59 PM, Arnaud Quette wrote:
Hi,

you will find attached  a patch that adds support for Eaton Switched ePDU to fence_eaton_snmp.
please consider applying it.

What do you think about replacing magic numbers (+1, -1, -3) with some constants with names?

something cleaner is scheduled with the new PDU type I'll be adding soon (not yet investigated).
I've added the present (2nd) too urgently for doing something clean... but it was still worth to release.

cheers,
Arnaud
--
Linux / Unix Expert R&D - Eaton - http://powerquality.eaton.com
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.free.fr/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]