[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [GFS2 PATCH] GFS2: eliminate i_generation from memory



Hi,

On Wed, 2011-03-23 at 09:55 -0400, Bob Peterson wrote:
> ----- Original Message -----
> | Hi,
> | 
> | We still need that, it is the generation number for NFS. Although it
> | is
> | also identical to the no_formal_ino in recent kernels,
> | 
> | Steve.
> 
> Are you saying that nfs manipulates gfs2's i_generation value in
> the incore gfs2_inode structure?  If so, that scares me; there
> should be an interface to do that.  If not, it must be for some
> future development, because we don't reference the value anywhere.
> 
> Regards,
> 
> Bob Peterson
> Red Hat File Systems

It is identical to the no_formal_ino in all recent kernels and we use
that value for NFS generation number purposes. Really we should be using
this value and not the no_formal_ino one, but the switch didn't get made
when the original change was made. Both values are identical, except for
very old versions of the code. I think we should retain this field
though, since it can be useful for debugging,

Steve.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]