[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [fence-virt PATCH] fix handling of VIR_DOMAIN_EVENT_STARTED



(11.10.27 16:23), Kazunori INOUE wrote:
> (2011/10/26 8:30), Lon Hohberger wrote:
>> On 09/19/2011 04:32 PM, Lon Hohberger wrote:
>>> On 09/13/2011 04:44 AM, Kazunori INOUE wrote:
>>>
>>>> I attached the patch for this problem.
>>>>
>>>> * Modified to send a SIGHUP to the primary thread from the secondary
>>>>       thread detects the start of the VM, and
>>>>       the primary thread is modified so as to select() the requests from
>>>>       the VM which started.
>>>
>>> That's certainly one way of doing it.  I might have used
>>> 'pthread_cond_singal'.
>>
>> I am sorry for the delay.
>>
>> I have a fix based on yours that uses a pipe to wake up select() rather
>> than pthread_kill; I'll attach it here.  This ends up being a bit lower
>> impact, as well; it doesn't require changing the main program - only the
>> serial/vmchannel plugin.
>>
>> Apart from that, the patch here is largely the same.
>>
>> Let me know what you think at your convenience.
>>
>> -- Lon
> 
> Hi, Lon
> 
> Thank you for your reply.
> I tested this patch, and confirmed that the problem was solved.
> (It was good also when four VM (s) was started simultaneously.)
> 
> Many thanks!

Hi,

Could you please merge?

Regards,
Kazunori INOUE


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]