[Cluster-devel] [coverity] cman

[Fabio M. Di Nitto]

Before:

Analysis summary report:
------------------------
Files analyzed                 : 27
Total LoC input to cov-analyze : 32029
Functions analyzed             : 380
Paths analyzed                 : 52124
New defects found              : 315 Total
                                   3 BAD_SIZEOF
                                  16 CHECKED_RETURN
                                   4 CONSTANT_EXPRESSION_RESULT
                                   1 DEADCODE
                                   5 FORWARD_NULL
                                   2 INTEGER_OVERFLOW
                                   1 MISSING_BREAK
                                   1 NEGATIVE_RETURNS
                                   5 NO_EFFECT
                                 139 NULL_RETURNS
                                   2 PW.DECLARED_BUT_NOT_REFERENCED
                                   1 PW.MAIN_WRONG_NUM_PARAMS
                                  13 PW.MIXED_ENUM_TYPE
                                   1 PW.NOT_COMPATIBLE_WITH_PREVIOUS_DECL
                                  12 PW.SET_BUT_NOT_USED
                                   7 RESOURCE_LEAK
                                   3 REVERSE_INULL
                                  51 SECURE_CODING
                                   3 SIZEOF_MISMATCH
                                   1 STRING_NULL
                                  12 STRING_OVERFLOW
                                   6 TAINTED_SCALAR
                                   1 TAINTED_STRING
                                   4 TOCTOU
                                  20 UNINIT
                                   1 UNUSED_VALUE

After:

Analysis summary report:
------------------------
Files analyzed                 : 27
Total LoC input to cov-analyze : 32078
Functions analyzed             : 379
Paths analyzed                 : 52565
New defects found              : 205 Total
                                   8 CHECKED_RETURN
                                   2 INTEGER_OVERFLOW
                                   2 NO_EFFECT
                                 134 NULL_RETURNS
                                   2 PW.DECLARED_BUT_NOT_REFERENCED
                                  12 PW.MIXED_ENUM_TYPE
                                   1 PW.NOT_COMPATIBLE_WITH_PREVIOUS_DECL
                                   6 PW.SET_BUT_NOT_USED
                                   4 RESOURCE_LEAK
                                  10 SECURE_CODING
                                   6 TAINTED_SCALAR
                                   1 TAINTED_STRING
                                   4 TOCTOU
                                  13 UNINIT

Of the remaining warnings,
12 PW.MIXED_ENUM_TYPE
 6 TAINTED_SCALAR
 1 TAINTED_STRING
need further investigation as the warning is non obvious at all.

All the others can be ignored.