[Cluster-devel] [PATCH 06/19] libccs: remove duplicate checks

Fabio M. Di Nitto fdinitto at redhat.com
Tue Oct 25 12:08:57 UTC 2011


Spotted by Coverity Scan

Signed-off-by: Fabio M. Di Nitto <fdinitto at redhat.com>
---
:100644 100644 703fa17... 3b2ab4b... M	config/libs/libccsconfdb/fullxpath.c
 config/libs/libccsconfdb/fullxpath.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/config/libs/libccsconfdb/fullxpath.c b/config/libs/libccsconfdb/fullxpath.c
index 703fa17..3b2ab4b 100644
--- a/config/libs/libccsconfdb/fullxpath.c
+++ b/config/libs/libccsconfdb/fullxpath.c
@@ -62,7 +62,7 @@ static int dump_objdb_buff(confdb_handle_t dump_handle, hdb_handle_t cluster_han
 		return -1;
 	}
 
-	if (!*buffer || ((*buffer) && !strlen(*buffer))) {
+	if (!strlen(*buffer)) {
 		snprintf(temp, PATH_MAX - 1,
 			 "<?xml version=\"1.0\"?>\n<cluster");
 		if (add_to_buffer(temp, buffer, bufsize))
-- 
1.7.4.4




More information about the Cluster-devel mailing list