[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] [PATCH 3/3] mkfs i18n:



Hi Carlos,

----- Original Message -----
| + do{
| + printf( _("\nAre you sure you want to proceed? [y/n]"));
| + ret = getline(&line, &len, stdin);
| + res = rpmatch(line);

I'd like to see the free(line); moved right here after rpmatch.
Otherwise multiple iterations through the loop will leak memory.

| +
| + if (res > 0){

With my suggestion above, this can be removed:
| + free(line);

Other than that, it looks good.

Regards,

Bob Peterson
Red Hat File Systems


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]