[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] [PATCH 2/2] fence_kdump: fix potential null dereference



If strchr returns NULL while parsing options from stdin, continue
without handling the option. This should prevent possible null
dereference.

rhbz#734429

Signed-off-by: Ryan O'Hara <rohara redhat com>
---
 fence/agents/kdump/fence_kdump.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fence/agents/kdump/fence_kdump.c b/fence/agents/kdump/fence_kdump.c
index 2844a3e..e224db3 100644
--- a/fence/agents/kdump/fence_kdump.c
+++ b/fence/agents/kdump/fence_kdump.c
@@ -427,6 +427,8 @@ get_options_stdin (fence_kdump_opts_t *opts)
         if ((arg = strchr (opt, '=')) != 0) {
             *arg = 0;
             arg += 1;
+        } else {
+            continue;
         }
 
         if (!strcasecmp (opt, "nodename")) {
-- 
1.7.3.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]