[Cluster-devel] [PATCH] gfs2/inode.c: local functions should be static
Steven Whitehouse
swhiteho at redhat.com
Mon Sep 26 08:27:38 UTC 2011
Hi,
On Fri, 2011-09-23 at 15:51 -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
>
> warning: symbol 'gfs2_initxattrs' was not declared. Should it be static?
>
Where did you find this function? It is not in the upstream gfs2 code...
Steve.
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Steven Whitehouse <swhiteho at redhat.com>
>
> ---
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 5431de9..5f2b157 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -624,7 +624,7 @@ fail:
> return error;
> }
>
> -int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> void *fs_info)
> {
> const struct xattr *xattr;
More information about the Cluster-devel
mailing list